cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13580) cordova-android 6.4.0 broke build if cdvBuildMultipleApks is set to true
Date Mon, 20 Nov 2017 23:59:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260044#comment-16260044
] 

ASF GitHub Bot commented on CB-13580:
-------------------------------------

fredgalvao commented on issue #417: CB-13580: (android) fix build for multiple apks (different
product flavors)
URL: https://github.com/apache/cordova-android/pull/417#issuecomment-345871371
 
 
   @DavidStrausz thank you for this.
   
   @infil00p Considering that the combination of the following aspects:
   - Oreo
   - crosswalk breakage
   - wave of plugin updates
   
   is quite important and that crosswalk usage is considerably high (my estimate, no data),
what are the chances of a 6.4.1/6.5.0 coming out soon to include this? I'm interested in your
PoV in this subject.
   I've seen many people delaying/cancelling upgrade plans because of that on the cordova
slack channels, and I'd say it would bring a lot of people/projects up to speed again (including
mine).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> cordova-android 6.4.0 broke build if cdvBuildMultipleApks is set to true
> ------------------------------------------------------------------------
>
>                 Key: CB-13580
>                 URL: https://issues.apache.org/jira/browse/CB-13580
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android
>    Affects Versions: 6.4.0
>            Reporter: David Strauß
>            Assignee: Joe Bowser
>              Labels: build
>
> With the latest cordova-android (6.4.0) builds for different product flavors (arm, x86)
do not work anymore (error e.g.: "No flavor is associated with flavor dimension ...")  because
of the changes introduced with gradle 3.0.0. With the new gradle plugin a flavorDimenson must
be specified to build different product flavors (mentioned [here|https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html?utm_source=android-studio#flavor_dimensions]
in the upgrade guide. This can be fixed by adding `flavorDimensions "default"` to build.gradle
if cdvBuildMultipleApks is set to true.
> Another change that was introduced with the new gradle version is that builds for different
architectures are put into their own directory (build/outputs/apk/<arch>/<debug|release>)
which results in APK files not being found (mentioned in the upgrade guide under the point
"Modifying variant outputs at build time may not work").
> This can be fixed by adapting the findOutputApksHelper method in GenericBuilder.js.
> An unfortunate side effect of these issues is that projects leveraging crosswalk do not
work anymore.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message