cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13555) (ios) Present notification view controller by inappbrowser view controller
Date Wed, 15 Nov 2017 22:19:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254319#comment-16254319
] 

ASF GitHub Bot commented on CB-13555:
-------------------------------------

jcesarmobile closed pull request #98: CB-13555 (ios) Present notification view controller
by inappbrowser view controller
URL: https://github.com/apache/cordova-plugin-dialogs/pull/98
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/ios/CDVNotification.m b/src/ios/CDVNotification.m
index 0dd3d2c..89f3d5d 100644
--- a/src/ios/CDVNotification.m
+++ b/src/ios/CDVNotification.m
@@ -228,8 +228,11 @@ - (void)beep:(CDVInvokedUrlCommand*)command
 
 -(UIViewController *)getTopPresentedViewController {
     UIViewController *presentingViewController = self.viewController;
-    while(presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController
isBeingDismissed])
-    {
+    if (presentingViewController.view.window != [UIApplication sharedApplication].keyWindow){
+        presentingViewController = [UIApplication sharedApplication].keyWindow.rootViewController;
+    }
+
+    while (presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController
isBeingDismissed]){
         presentingViewController = presentingViewController.presentedViewController;
     }
     return presentingViewController;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> (ios) Present notification view controller by inappbrowser view controller
> --------------------------------------------------------------------------
>
>                 Key: CB-13555
>                 URL: https://issues.apache.org/jira/browse/CB-13555
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-dialogs
>    Affects Versions: cordova-ios 4.5.0
>         Environment: IOS 10 and 11
>            Reporter: Jonathan Li
>              Labels: dialog, inappbrowser
>             Fix For: Master
>
>
> When inappbrowser window is shown, if main uiwebview or wkwebview calls cordova Dialog
plugin method to show the dialog view, the dialog should show to user on top of the inappbrowser
view controller.
> However, currently the dialog view is shown behind the inappbrowser view, so user cannot
see it or click button on the dialog 
> An similar issue was reported for barcode scanner plugin at 
> https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/570
> The issue can be repeated with the below method
> function confirm(){
>     var win = window.open( "https://www.google.com", "_blank" );
>     win.addEventListener( "loadstop", function() {
>     setTimeout(function() {
>          function onConfirm(buttonIndex) {
>             console.log('You selected button ' + buttonIndex);
>         }
>         
>         navigator.notification.confirm(
>             'You are the winner!', // message
>             onConfirm,            // callback to invoke with index of button pressed
>             'Game Over',           // title
>             ['Restart','Exit']     // buttonLabels
> );
>     }, 1000 );
> });
> }



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message