cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
Date Wed, 15 Nov 2017 19:32:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254014#comment-16254014
] 

ASF GitHub Bot commented on CB-13543:
-------------------------------------

janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation
around travis build/dep…
URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151228684
 
 

 ##########
 File path: doc/building-and-deploying-the-website.md
 ##########
 @@ -0,0 +1,20 @@
+## Building and Deploying (Automated)
+
+### Testing
+
+After you are finished developing and making your changes, make sure to test them. Run:
+
+	npm test
+
+`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your
work to Github.
+
+### Travis 
+
+[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml),
Travis  installs required dependencies and runs the build script. Travis will build the full
website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update,
copy, add, and commit the new changes over to the website. Committing to svn can only occur
once the commit has been merged to master. You can read more about is happening under the
hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify
you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and
deploying, send a pull request and ask for a review.
 
 Review comment:
   Ok, maybe this should be explain a bit here and the workflow clarified?
   
   You fork, commit your changes to your fork, wait for the test result via Travis.
   If green, you can send the PR which will trigger Travis again.
   If (green and) merged, it will trigger a deploy.
   
   Correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Automate build/deploy for cordova-docs
> --------------------------------------
>
>                 Key: CB-13543
>                 URL: https://issues.apache.org/jira/browse/CB-13543
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-docs
>            Reporter: Audrey So
>            Assignee: Audrey So
>              Labels: enhancement, feature, in-progress, optimization
>
> Automate build/deploy for cordova-docs
> Cordova-docs should be built and published automatically on every change
> Replace jsihnt with eslint
> Update README.md & update instructions in docs to reflect changes
> https://issues.apache.org/jira/browse/CB-13162



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message