cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13532) Cordova fails to find platform/plugin versions in package.json devDependencies
Date Wed, 08 Nov 2017 19:17:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244575#comment-16244575
] 

ASF GitHub Bot commented on CB-13532:
-------------------------------------

audreyso opened a new pull request #607: :CB-13532 : updated to include a check for pkgJson
devDependencies
URL: https://github.com/apache/cordova-lib/pull/607
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   
   ### What does this PR do?
   include a check for pkgJson devDependencies
   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [X] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Cordova fails to find platform/plugin versions in package.json devDependencies
> ------------------------------------------------------------------------------
>
>                 Key: CB-13532
>                 URL: https://issues.apache.org/jira/browse/CB-13532
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>            Reporter: Darryl Pogue
>              Labels: tools-next
>
> Cordova only looks at the {{dependencies}} section of package.json, and ignores anything
specified in {{devDependencies}}. This results in the default pinned versions for platforms/plugins
being used.
> Code in question: https://github.com/apache/cordova-lib/blob/da8ebf6cb81dd84c22e24fdf0baff9837a544b2d/src/cordova/platform/addHelper.js#L109-L113
> This is wrong because Cordova (and its related bits) is not a dependency of my application
code, it is a build tool that belongs in devDependencies.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message