cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13498) (inappbrowser) Add closebutton option for ios
Date Thu, 30 Nov 2017 07:59:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272295#comment-16272295
] 

ASF GitHub Bot commented on CB-13498:
-------------------------------------

jaapjanfrans commented on issue #247: CB-13498 added closebutton option for ios
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-348110795
 
 
   I understand your concern @surajpindoria 
   
   I think we're save with our app because of the way we add some functionality that is not
available in the web variant, but i share your concern.
   
   I think it's a bit far fetched to say that this PR will lead people to the dark side of
empty wrapper apps, but i also think the're more important things in the world than this little
feature. We spent more time talking about it now than it takes a dev to add the feature to
his own codebase if he has the need for this ;-)
   
   So Let's close this one. Thanks for your input!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> (inappbrowser) Add closebutton option for ios
> ---------------------------------------------
>
>                 Key: CB-13498
>                 URL: https://issues.apache.org/jira/browse/CB-13498
>             Project: Apache Cordova
>          Issue Type: New Feature
>            Reporter: Jaap-Jan
>
> On ios the toolbar has a close button and back/next buttons. You can disable the entire
toolbar, but not disable the close button only.
> If a closebutton option is support, you can have a toolbar that only has the navigational
buttons. 
> I needed this for a project that needs to keep the inappbrowser opened at all times (so
a close button should not be shown)  but also requires to have navigational buttons of the
toolbar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message