cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13498) (inappbrowser) Add closebutton option for ios
Date Wed, 29 Nov 2017 21:53:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271591#comment-16271591
] 

ASF GitHub Bot commented on CB-13498:
-------------------------------------

surajpindoria commented on issue #247: CB-13498 added closebutton option for ios
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-348008734
 
 
   @jaapjanfrans,
   
   I had a feeling that this is what you were trying to accomplish by removing the close button.
Another question, have you tried to release this app to the store before? Typically Apple
will not approve apps that are simply a wrapper for a website. They will also check to see
how your app functions in an offline mode, which could be another reason it would get rejected.
If you have a chance please check out this detailed [post](https://forums.adobe.com/message/9741806#9741806)
by another Cordova contributor with regards to this situation.
   
   With that said, I still stand by my original opinion that this should not be merged in.
I agree with you that this is a trivial change, but it would be encouraging behavior that
would likely result in peoples apps being rejected by Apple.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> (inappbrowser) Add closebutton option for ios
> ---------------------------------------------
>
>                 Key: CB-13498
>                 URL: https://issues.apache.org/jira/browse/CB-13498
>             Project: Apache Cordova
>          Issue Type: New Feature
>            Reporter: Jaap-Jan
>
> On ios the toolbar has a close button and back/next buttons. You can disable the entire
toolbar, but not disable the close button only.
> If a closebutton option is support, you can have a toolbar that only has the navigational
buttons. 
> I needed this for a project that needs to keep the inappbrowser opened at all times (so
a close button should not be shown)  but also requires to have navigational buttons of the
toolbar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message