cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13208) File plugin on Windows reads entire file into memory when only a small fragment is requested on `readAsBinaryString`
Date Tue, 14 Nov 2017 09:08:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251115#comment-16251115
] 

ASF GitHub Bot commented on CB-13208:
-------------------------------------

salbahra commented on issue #216: CB-13208: (windows) Fix `readAsBinaryString` to only read
the requested range
URL: https://github.com/apache/cordova-plugin-file/pull/216#issuecomment-344190974
 
 
   Any status update on this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> File plugin on Windows reads entire file into memory when only a small fragment is requested
on `readAsBinaryString`
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-13208
>                 URL: https://issues.apache.org/jira/browse/CB-13208
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-file
>    Affects Versions: 6.5.0
>         Environment: All Windows UAP applications
>            Reporter: Samer Albahra
>
> `readAsBinaryString` for `FileReader` on Windows is reading the entire file to a buffer
then slicing the requested fragment causing the app to crash due to out of memory errors.
It should instead be using a stream which seeks to the requested start position and only reads
the requested length.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message