cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13076) Sunset cordova-plugin-device-orientation
Date Thu, 02 Nov 2017 23:35:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236821#comment-16236821
] 

ASF GitHub Bot commented on CB-13076:
-------------------------------------

stevengill closed pull request #155: CB-13076 , CB-13068 : Removed references of cordova device
motion and cordova device orientation plugins
URL: https://github.com/apache/cordova-coho/pull/155
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/doc-translation-process.md b/docs/doc-translation-process.md
index 6d03ceb..193b8e2 100644
--- a/docs/doc-translation-process.md
+++ b/docs/doc-translation-process.md
@@ -105,7 +105,7 @@ Finally, it pushes the translated language files back into github.
     
     #--- git repos
     ## declare an array variable
-    declare -a gitrepos=("cordova-docs" "cordova-cli" "cordova-plugin-battery-status" "cordova-plugin-camera"
"cordova-plugin-console" "cordova-plugin-contacts" "cordova-plugin-device" "cordova-plugin-device-motion"
"cordova-plugin-device-orientation" "cordova-plugin-dialogs" "cordova-plugin-file" "cordova-plugin-file-transfer"
"cordova-plugin-geolocation" "cordova-plugin-globalization" "cordova-plugin-inappbrowser"
"cordova-plugin-media" "cordova-plugin-media-capture" "cordova-plugin-network-information"
"cordova-plugin-splashscreen" "cordova-plugin-statusbar" "cordova-plugin-vibration")
+    declare -a gitrepos=("cordova-docs" "cordova-cli" "cordova-plugin-battery-status" "cordova-plugin-camera"
"cordova-plugin-console" "cordova-plugin-contacts" "cordova-plugin-device" "cordova-plugin-dialogs"
"cordova-plugin-file" "cordova-plugin-file-transfer" "cordova-plugin-geolocation" "cordova-plugin-globalization"
"cordova-plugin-inappbrowser" "cordova-plugin-media" "cordova-plugin-media-capture" "cordova-plugin-network-information"
"cordova-plugin-splashscreen" "cordova-plugin-statusbar" "cordova-plugin-vibration")
     
     
     read -p "What is the name of the JIRA issue?" jira
diff --git a/docs/plugins-release-process.md b/docs/plugins-release-process.md
index 22c23bf..28f5c28 100644
--- a/docs/plugins-release-process.md
+++ b/docs/plugins-release-process.md
@@ -73,7 +73,7 @@ TODO: Should not mention testing other than checking medic
 
 If you don't want to release all plugins, but you have specific plugins you want to release,
you need to set `ACTIVE` equal to them.
 
-    ACTIVE="cordova-plugin-camera cordova-plugin-contacts cordova-plugin-device-motion"
+    ACTIVE="cordova-plugin-camera cordova-plugin-contacts"
     echo $ACTIVE
 
 ## Ensure license headers are present everywhere:
diff --git a/src/repoutil.js b/src/repoutil.js
index 74c537e..263323d 100644
--- a/src/repoutil.js
+++ b/src/repoutil.js
@@ -189,12 +189,14 @@ var pluginRepos = [
         title: 'Plugin - Device Motion',
         id: 'plugin-device-motion',
         repoName: 'cordova-plugin-device-motion',
-        jiraComponentName: 'cordova-plugin-device-motion'
+        jiraComponentName: 'cordova-plugin-device-motion',
+        inactive: true
     }, {
         title: 'Plugin - Device Orientation',
         id: 'plugin-device-orientation',
         repoName: 'cordova-plugin-device-orientation',
-        jiraComponentName: 'cordova-plugin-device-orientation'
+        jiraComponentName: 'cordova-plugin-device-orientation',
+        inactive: true
     }, {
         title: 'Plugin - Device',
         id: 'plugin-device',
diff --git a/test/flagutil.test.js b/test/flagutil.test.js
index 27599f8..2e555e9 100644
--- a/test/flagutil.test.js
+++ b/test/flagutil.test.js
@@ -220,23 +220,6 @@ test('test computeReposFromFlagDocs', function(t) {
     t.equal(repo[0].id, 'docs');
     t.equal(repo[0].repoName, 'cordova-docs');
 });
-test('test computeReposFromFlagPluginDeviceMotion', function(t) {
-    t.plan(4);
-    var repo = flagutil.computeReposFromFlag('plugin-device-motion');
-    t.equal(repo.length, 1);
-    t.equal(typeof repo[0], 'object');
-    t.equal(repo[0].id, 'plugin-device-motion');
-    t.equal(repo[0].repoName, 'cordova-plugin-device-motion');
-});
-test('test computeReposFromFlagPluginDeviceOrientation', function(t) {
-    t.plan(4);
-    var repo = flagutil.computeReposFromFlag('plugin-device-orientation');
-    t.equal(repo.length, 1);
-    t.equal(typeof repo[0], 'object');
-    t.equal(repo[0].id, 'plugin-device-orientation');
-    t.equal(repo[0].repoName, 'cordova-plugin-device-orientation');
-});
-
 test('test computeReposFromFlagPlugin-device', function(t) {
     t.plan(4);
     var repo = flagutil.computeReposFromFlag('plugin-device');


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Sunset cordova-plugin-device-orientation
> ----------------------------------------
>
>                 Key: CB-13076
>                 URL: https://issues.apache.org/jira/browse/CB-13076
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: cordova-plugin-device-orientation (DEPRECATED)
>            Reporter: Filip Maj
>            Assignee: Vishal Mishra
>            Priority: Major
>              Labels: plugins-next
>
> Todo (see subtasks):
> 1. Deprecate JIRA components.
> 2. Close out all github PRs and JIRA issues.
> 3. What do we need to inform Apache Infra of? 
> 4. Update plugin README to reflect status of plugin and point to transition blog post.
> 5. Update coho to remove any references to the plugin.
> 6. Update cordova-docs to remove plugin references / remove code generation around cordova-plugin-device-orientation.
> 7. Do one final release of the plugin.
> 8. Ensure we deprecate the plugin in npm.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message