Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 24 Oct 2017 22:51:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13110459.1508357154000.51276.1508885460064@Atlassian.JIRA>
In-Reply-To: <JIRA.13110459.1508357154000@Atlassian.JIRA>
References: <JIRA.13110459.1508357154000@Atlassian.JIRA> <JIRA.13110459.1508357154913@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-13463) No way to prevent package.json update
 with cordova commands even with --nosave
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 24 Oct 2017 22:51:04 -0000


    [ https://issues.apache.org/jira/browse/CB-13463?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D162178=
40#comment-16217840 ]=20

ASF GitHub Bot commented on CB-13463:
-------------------------------------

Github user stevengill commented on the issue:

    https://github.com/apache/cordova-lib/pull/599
 =20
    LGTM, but the ci failures =F0=9F=98=A8=20


> No way to prevent package.json update with cordova commands even with --n=
osave
> -------------------------------------------------------------------------=
-----
>
>                 Key: CB-13463
>                 URL: https://issues.apache.org/jira/browse/CB-13463
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-cli
>    Affects Versions: cordova@7.0.0
>            Reporter: Andrew Crites
>              Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and {=
{cordova prepare}} will copy plugin information from {{config.xml}} to {{pa=
ckage.json}}.=20
> According to [the saving platforms documentation|https://cordova.apache.o=
rg/docs/en/latest/platform_plugin_versioning_ref/], using {{--nosave}} shou=
ld prevent updating {{package.json}} or {{config.xml}}, but this does not w=
ork (i.e. using {{--nosave}} still seems to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there does=
n't seem to be a way to avoid hard coding variables for plugins. An example=
 is the cordova fabric plugin:
> {code}
>   <plugin name=3D"cordova-fabric-plugin" spec=3D"^1.1.9">
>     <variable name=3D"FABRIC_API_KEY" value=3D"a" />
>     <variable name=3D"FABRIC_API_SECRET" value=3D"b" />
>   </plugin>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables i=
n the configuration. To get around this, I have {{build.config.xml}} where =
they are parameterized, and {{config.xml}} is created at install-time and n=
ot version controlled. However, this would be much more difficult to do wit=
h {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,=
 cordova still updates {{package.json}} to include the fabric plugin with t=
he hard coded variables.
> * Cordova 6 question (with solution): https://stackoverflow.com/questions=
/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet) https://stackoverflow.com/question=
s/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordo=
va-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Eve=
n better, there should be a way to set up a cordova project so that any cor=
dova commands do not save by default. This would prevent mistakes in a larg=
er team and allow use of tools that wrap cordova such as ionic.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org