Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 25 Oct 2017 23:34:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13070400.1494333899000.63203.1508974440084@Atlassian.JIRA>
In-Reply-To: <JIRA.13070400.1494333899000@Atlassian.JIRA>
References: <JIRA.13070400.1494333899000@Atlassian.JIRA> <JIRA.13070400.1494333899569@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-12774) cordova plugin add doesn't support
 npm scope
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 25 Oct 2017 23:34:04 -0000


    [ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219735#comment-16219735 ] 

ASF GitHub Bot commented on CB-12774:
-------------------------------------

Github user audreyso commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/602#discussion_r147014589
  
    --- Diff: src/cordova/util.js ---
    @@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
         var plugins = [];
     
         if (fs.existsSync(pluginDir)) {
    -        plugins = fs.readdirSync(pluginDir).filter(function (fileName) {
    -            var pluginPath = path.join(pluginDir, fileName);
    -            var isPlugin = isDirectory(pluginPath) || isSymbolicLink(pluginPath);
    -            return fileName !== '.svn' && fileName !== 'CVS' && isPlugin;
    -        });
    +        plugins = fs.readdirSync(pluginDir)
    +            .reduce(function (plugins, pluginOrScope) {
    +                if (pluginOrScope[0] === '@') {
    +                    plugins.push(...fs.readdirSync(path.join(pluginDir, pluginOrScope)).map(s => path.join(pluginOrScope, s)));
    --- End diff --
    
    Thanks for your question! We are sticking to the current style for now. We need to have a discussion on our mailing list about starting to use es2015 features/ which ones to use and get some consensus.


> cordova plugin add doesn't support npm scope
> --------------------------------------------
>
>                 Key: CB-12774
>                 URL: https://issues.apache.org/jira/browse/CB-12774
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-fetch
>    Affects Versions: 1.1.0
>            Reporter: Enrico Mazzucchelli
>              Labels: cordova-8.0.0
>             Fix For: 1.1.1
>
>
> STEP TO REPRODUCE:
> 1) setup a private repo (for example sinopia with docker: https://github.com/kfatehi/docker-sinopia)
> 2) add scope in your npm config:  npm config set @myco:registry http://0.0.0.0:4873/
> 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in plugin.xml set plugin id: @myco/my.co.plugin.demo.
> 3) publish plugin in your private repo:
>     - npm set registry http://0.0.0.0:4873
>     - npm publish
>    -  npm set registry https://registry.npmjs.org/
> 4) in your cordova project dir, exec:
>     cordova plugin add @myco/my.co.plugin.demo
> EXPECTED BEHAVIOR:
>   cordova plugin are installed 
> ACTUAL BEHAVIOR:
>   cordova installation failed:
>   Error: Failed to fetch plugin my.co.plugin.demo via registry.
>   Probably this is either a connection problem, or plugin spec is incorrect.
>   Check your connection and plugin name/version/URL.
>   Error: npm: Command failed with exit code 1 Error output:
>   npm ERR! code E404
>   npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/my.co.plugin.demo
>   npm ERR! 404 
>   npm ERR! 404  'com.vipera.de.foundation.commons' is not in the npm registry.
>   npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
>   npm ERR! 404 
>   npm ERR! 404 Note that you can also install from a
>   npm ERR! 404 tarball, folder, http url, or git url.
> However node module are correctly installed (verified with npm ls) and fetch.json have a new entry with key
> @my.co.plugin.demo.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org