cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13498) (inappbrowser) Add closebutton option for ios
Date Thu, 26 Oct 2017 14:11:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220479#comment-16220479
] 

ASF GitHub Bot commented on CB-13498:
-------------------------------------

GitHub user jaapjanfrans opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/247

    CB-13498 added closebutton option for ios

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    ios
    
    ### What does this PR do?
    Adds the option on ios to enable or disable the close button in the toolbar. I needed
this for an app that should not display a close button but should show the toolbar because
of the previous/next navigational buttons.
    
    ### What testing has been done on this change?
    Run automated tests as outlined here for platform ios
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaapjanfrans/cordova-plugin-inappbrowser feature/closebutton

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/247.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #247
    
----
commit bf24e4ed49ea8790f399f561d9d4c6289a3c9f59
Author: Jaap-Jan Frans <jaapjan@gmail.com>
Date:   2017-10-26T13:13:26Z

    CB-13498: (ios) Added closebutton option to be able to enable or disable the close button
in the toolbar

----


> (inappbrowser) Add closebutton option for ios
> ---------------------------------------------
>
>                 Key: CB-13498
>                 URL: https://issues.apache.org/jira/browse/CB-13498
>             Project: Apache Cordova
>          Issue Type: New Feature
>            Reporter: Jaap-Jan
>
> On ios the toolbar has a close button and back/next buttons. You can disable the entire
toolbar, but not disable the close button only.
> If a closebutton option is support, you can have a toolbar that only has the navigational
buttons. 
> I needed this for a project that needs to keep the inappbrowser opened at all times (so
a close button should not be shown)  but also requires to have navigational buttons of the
toolbar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message