cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-13478) Windows line endings in cordova-lib
Date Sat, 21 Oct 2017 00:47:00 GMT


ASF GitHub Bot commented on CB-13478:

GitHub user akdor1154 opened a pull request:

    CB-13478 : Fix CRLF line endings and lint integration tests.

    ### Platforms affected
    ### What does this PR do?
    - Change CRLFs to LFs
    - Configures eslint to whinge in future if CRLFs sneak back in
    - Adds gitattributes to prevent this in future
    - Adds integration-tests to the eslint script, and fixes lint errors it found in there
(mainly line endings).
    ### What testing has been done on this change?
    `npm run eslint`
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull lf

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #600
commit 87ec94735455976130e2ec0dcaa0d2d72b2995de
Author: Jarrad Whitaker <>
Date:   2017-10-21T00:25:36Z

    eslint and gitattributes to ensure LF

commit 878c5ce45523223f3fe1c1b731367c66f87b7dcb
Author: Jarrad Whitaker <>
Date:   2017-10-21T00:27:01Z

    crlf -> lf with eslint

commit ce8157585db744bce82cd6f1b5224f58aa948f68
Author: Jarrad Whitaker <>
Date:   2017-10-21T00:29:29Z

    lint integration tests too

commit 4a5ce48dd0c7ded0429e3655c2ec0eb4e58bb2f2
Author: Jarrad Whitaker <>
Date:   2017-10-21T00:32:26Z

    crlf -> lf in integration tests

commit 4c6ef8a98c9147a992c70ed015fe5eed28be944e
Author: Jarrad Whitaker <>
Date:   2017-10-21T00:33:27Z

    eslint --fix in integration-tests

commit afee24c3e6ffe3c65015abd6180aee464434ce76
Author: Jarrad Whitaker <>
Date:   2017-10-21T00:34:37Z

    eqeqeq in HooksRunner


> Windows line endings in cordova-lib
> -----------------------------------
>                 Key: CB-13478
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>    Affects Versions: cordova@7.0.0
>            Reporter: Jarrad Whitaker
>            Priority: Trivial
>              Labels: lint
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> A few files in cordova-lib have snuck in with CRLFs.
> I will open a pr with
> - eslint set to error on crlfs
> - gitattributes to prevent more crlfs
> - files with crlf translated to lf

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message