cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13451) "pkg not defined" exception when running plugman with createpackagejson command-line
Date Fri, 20 Oct 2017 21:52:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213300#comment-16213300
] 

ASF GitHub Bot commented on CB-13451:
-------------------------------------

Github user OminousWater commented on the issue:

    https://github.com/apache/cordova-lib/pull/597
  
    Thanks for picking up on those problems -- how embarrassing! The lines removed from .eslintignore
was a complete mistake on my part, thank you for spotting that. I've re-instated those lines,
and revised the glob patterns at the same time, as the ones that were there didn't seem to
be doing what they were intended to, with the latest version of eslint. I also removed the
now-redundant eslint directives from init-default.js. Do you know how I can trigger another
Continous Integration run on the server to check everything's good?


> "pkg not defined" exception when running plugman with createpackagejson command-line
> ------------------------------------------------------------------------------------
>
>                 Key: CB-13451
>                 URL: https://issues.apache.org/jira/browse/CB-13451
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Roland
>            Priority: Minor
>
> NOTE: I am about to submit a pull request with a fix for this issue. Description follows:
> A global js-lint pass on the cordova-lib codebase on the 30/8/2017 caused references
to the global 'package' variable in init-default.js to be renamed to 'pkg', presumably because
the cordova-lib source doesn't declare a global variable called 'package' but _does_ declare
a global variable called 'pkg' (in cordova/info.js). However in this case, the 'package' variable
refers to the one declared in the plugman source, specifically main.js, so it should have
stayed as 'package'. To test the fix, run:
> 	plugman createpackagejson .
> Without the fix, this will trigger the following exception: 'pkg is not defined'. Having
patched in the fix, running the command line should work as expected, prompting the user with
questions and then spitting out a package.json file.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message