cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
Date Fri, 06 Oct 2017 15:17:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194729#comment-16194729
] 

ASF GitHub Bot commented on CB-13396:
-------------------------------------

Github user Lazza commented on the issue:

    https://github.com/apache/cordova-plugin-splashscreen/pull/135
  
    Actually, the code of this plugin need not be changed. However, the `cordova-ios` template
needs a fix. I am using `cordova-ios@4.5.1` and I've added this to my `hooks/after_prepare/`
directory:
    
    ```
    NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')"
    sed -i '' 's_secondItem="xb3-aO-Qok" secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g'
"$NAME"
    ```
    
    Basically, there is a wrong constraint in `CDVLaunchScreen.storyboard`. If this is fixed,
nothing else needs to be changed.


> Splash screen images are resized incorrectly on iPhone X
> --------------------------------------------------------
>
>                 Key: CB-13396
>                 URL: https://issues.apache.org/jira/browse/CB-13396
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-splashscreen
>         Environment: iOS 11 / iPhone X
>            Reporter: Ken Mickles
>              Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into account, causing
the image size to change when CDVLaunchScreen.storyboard transitions to the CDVSplashScreen
image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message