cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape
Date Thu, 12 Oct 2017 22:48:02 GMT

    [ https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202750#comment-16202750
] 

ASF GitHub Bot commented on CB-13394:
-------------------------------------

GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/89

    CB-13394: (iOS) fix iPhone X StatusBar rendering in landscape

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    iPhone X don't show the status bar in landscape, this PR handles that and also resizes
the webview accordingly 
    The downside is it brings CB-10158 back, we need to find another way of fishing it, but
at least it has a workaround.
    
    ### What testing has been done on this change?
    Tested on iPhone 8 and iPhone X simulators
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar CB-13394

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit 26a5a8e1adaffdba6aa506115a71e9d45d74a6eb
Author: Julio C├ęsar <jcesarmobile@gmail.com>
Date:   2017-10-12T22:42:50Z

    CB-13394 (iOS): fix iPhone X StatusBar rendering in landscape

----


> iPhone X StatusBar rendering in landscape
> -----------------------------------------
>
>                 Key: CB-13394
>                 URL: https://issues.apache.org/jira/browse/CB-13394
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-statusbar
>    Affects Versions: cordova-ios 4.5.0
>         Environment: iPhone X, iOS11 landscape mode
>            Reporter: Dan Field
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status indicators
is rendered that covers content in the web view.  Default applications on the phone hide the
status bar when in landscape; this seems to be the preferable solution, as the landscape statusbar
shows no information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message