cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13290) SplashScreen dont handle iPhone X asset catalog image
Date Wed, 25 Oct 2017 14:08:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218688#comment-16218688
] 

ASF GitHub Bot commented on CB-13290:
-------------------------------------

kerrishotts commented on a change in pull request #344: CB-13290: (ios) Update splash screen
mapping for missing devices
URL: https://github.com/apache/cordova-ios/pull/344#discussion_r146868190
 
 

 ##########
 File path: bin/templates/scripts/cordova/lib/prepare.js
 ##########
 @@ -411,7 +411,9 @@ function mapSplashScreenResources (splashScreens, splashScreensDir) {
         {dest: 'Default-568h@2x~iphone.png', width: 640, height: 1136},
         {dest: 'Default-667h.png', width: 750, height: 1334},
         {dest: 'Default-736h.png', width: 1242, height: 2208},
-        {dest: 'Default-Landscape-736h.png', width: 2208, height: 1242}
+        {dest: 'Default-Landscape-736h.png', width: 2208, height: 1242},
+        {dest: 'Default-2436h.png', width: 1125, height: 2436},
+        {dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125}
 
 Review comment:
   Yeah, the lack of support for larger screens is the reason we added launch storyboard support.
IIRC there are hacks to use launch images for the 12.9” iPad Pro, but I don’t think you’d
ever get Xcode to be happy with them. (Personally I fully expected Apple to require launch
storyboards for the new iPhone X. Surprised they aren’t!)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> SplashScreen dont handle iPhone X asset catalog image
> -----------------------------------------------------
>
>                 Key: CB-13290
>                 URL: https://issues.apache.org/jira/browse/CB-13290
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-splashscreen
>    Affects Versions: cordova-ios 4.5.0
>            Reporter: Stefano Boeri
>
> I've digged into source code but i dont see anything related to iPhone X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message