cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13289) Gradle/Android Plugin DSL change breaks including CordovaLib
Date Tue, 31 Oct 2017 18:04:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227228#comment-16227228
] 

ASF GitHub Bot commented on CB-13289:
-------------------------------------

codecov-io commented on issue #413: CB-13289: This fixes the Cordova-Android build on cordova-android
6.x
URL: https://github.com/apache/cordova-android/pull/413#issuecomment-339514900
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=h1) Report
   > Merging [#413](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-android/commit/04fa5d3febe69d7adc91d1e603118f3d33af2606?src=pr&el=desc)
will **increase** coverage by `0.23%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/413/graphs/tree.svg?width=650&src=pr&token=q14nMf6C5a&height=150)](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #413      +/-   ##
   ==========================================
   + Coverage   43.77%   44.01%   +0.23%     
   ==========================================
     Files          17       17              
     Lines        1688     1679       -9     
     Branches      307      304       -3     
   ==========================================
     Hits          739      739              
   + Misses        949      940       -9
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz)
| `48.13% <0%> (+1.52%)` | :arrow_up: |
   | [...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
| `20.71% <0%> (+0.29%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=footer).
Last update [04fa5d3...47e20da](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Gradle/Android Plugin DSL change breaks including CordovaLib
> ------------------------------------------------------------
>
>                 Key: CB-13289
>                 URL: https://issues.apache.org/jira/browse/CB-13289
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android
>    Affects Versions: 6.2.1
>            Reporter: Joe Bowser
>            Assignee: Joe Bowser
>            Priority: Blocker
>              Labels: android-next
>             Fix For: 7.0.0
>
>
> Android Studio 3.0.0 uses a new DSL, and this breaks the dependency list.  This directly
affects Cordova plugins that work as a Library Module, as well as adding and removing the
Android platform.  Basically, once Android Studio 3.0 updates, Cordova projects will not work
properly with the new version of Android Studio once they're updated.
> This depends on CB-11244



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message