cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Olszowka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12754) inAppBrowser crashing on Android
Date Mon, 16 Oct 2017 21:29:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206619#comment-16206619
] 

Peter Olszowka commented on CB-12754:
-------------------------------------

So my code definitely calls inAppBrowser.open() after it calls .close() unless the loadstop
event is getting fired on .close() or on the 2nd .open() before I've even added the listener
again.  Which do you think might be happening?  How about removing all event listeners on
the .close()  Note, I'm calling removeEventListener("loadstop"... at some point, but it seems
to fire after doing that anyway.

Also, could you handle the error by returning true from successful .show() and returning false
from this error condition?

  --PeterO

On 10/16/17, 4:31 PM, "Joe Bowser (JIRA)" <jira@apache.org> wrote:

    
        [ https://issues.apache.org/jira/browse/CB-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206555#comment-16206555
] 
    
    Joe Bowser commented on CB-12754:
    ---------------------------------
    
    [~olszowka] Handle the error how? We can hide the exception, but what should we actually
do here?  If someone closes a dialog, does that mean it should be closed or just hidden? 
    
    > inAppBrowser crashing on Android
    > --------------------------------
    >
    >                 Key: CB-12754
    >                 URL: https://issues.apache.org/jira/browse/CB-12754
    >             Project: Apache Cordova
    >          Issue Type: Bug
    >          Components: cordova-android, cordova-plugin-inappbrowser
    >            Reporter: Peter Olszowka
    >
    > Using cordova-plugin-inappbrowser version 1.7.0
    > Getting many crash reports from Google play store with following stack trace:
    > java.lang.NullPointerException: Attempt to invoke virtual method 'void org.apache.cordova.inappbrowser.InAppBrowserDialog.show()'
on a null object reference
    > 	at org.apache.cordova.inappbrowser.InAppBrowser$2.run(InAppBrowser.java:257)
    > 	at android.os.Handler.handleCallback(Handler.java:739)
    > 	at android.os.Handler.dispatchMessage(Handler.java:95)
    > 	at android.os.Looper.loop(Looper.java:145)
    > 	at android.app.ActivityThread.main(ActivityThread.java:6126)
    > 	at java.lang.reflect.Method.invoke(Native Method)
    > 	at java.lang.reflect.Method.invoke(Method.java:372)
    > 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1399)
    > 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1194)
    > The issue appears on many versions of Android including 4.4, 5.1, 6.0, & 7.0.
    > You can try the app from the Google Play store: "cargurus"  
    > I am unable to reproduce the error myself, but 25 users/day are reporting it.
    
    
    
    --
    This message was sent by Atlassian JIRA
    (v6.4.14#64029)
    



> inAppBrowser crashing on Android
> --------------------------------
>
>                 Key: CB-12754
>                 URL: https://issues.apache.org/jira/browse/CB-12754
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android, cordova-plugin-inappbrowser
>            Reporter: Peter Olszowka
>
> Using cordova-plugin-inappbrowser version 1.7.0
> Getting many crash reports from Google play store with following stack trace:
> java.lang.NullPointerException: Attempt to invoke virtual method 'void org.apache.cordova.inappbrowser.InAppBrowserDialog.show()'
on a null object reference
> 	at org.apache.cordova.inappbrowser.InAppBrowser$2.run(InAppBrowser.java:257)
> 	at android.os.Handler.handleCallback(Handler.java:739)
> 	at android.os.Handler.dispatchMessage(Handler.java:95)
> 	at android.os.Looper.loop(Looper.java:145)
> 	at android.app.ActivityThread.main(ActivityThread.java:6126)
> 	at java.lang.reflect.Method.invoke(Native Method)
> 	at java.lang.reflect.Method.invoke(Method.java:372)
> 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1399)
> 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1194)
> The issue appears on many versions of Android including 4.4, 5.1, 6.0, & 7.0.
> You can try the app from the Google Play store: "cargurus"  
> I am unable to reproduce the error myself, but 25 users/day are reporting it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message