cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13342) Update README.md for cordova-plugin-test-framework regarding package.json
Date Fri, 29 Sep 2017 23:50:02 GMT

    [ https://issues.apache.org/jira/browse/CB-13342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186698#comment-16186698
] 

ASF GitHub Bot commented on CB-13342:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-test-framework/pull/27#discussion_r141247457
  
    --- Diff: README.md ---
    @@ -62,6 +62,10 @@ Add a directory named `tests` to the root of your plugin. Within this
directory,
     
     For example, the `cordova-plugin-device` plugin has this nested [`plugin.xml`](https://github.com/apache/cordova-plugin-device/blob/master/tests/plugin.xml).
     
    +Create a `package.json` inside your project's `tests/` folder. The latest version of
the tools ensure to run `npm install` on any plugin added to a project and pull in any dependencies.
Therefore, plugin authors can now put npm dependencies around their tests into the `package.json`
file.
    +
    +For example,the `cordova-plugin-device` plugin contains a [`package.json`](https://github.com/apache/cordova-plugin-device/blob/736c7b9dfdfa25a924ffc3d1e409450633a8c00f/tests/package.json).
    --- End diff --
    
    can you replace this link with the master version. https://github.com/apache/cordova-plugin-device/blob/master/tests/package.json


> Update README.md for cordova-plugin-test-framework regarding package.json
> -------------------------------------------------------------------------
>
>                 Key: CB-13342
>                 URL: https://issues.apache.org/jira/browse/CB-13342
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-test-framework
>            Reporter: Audrey So
>            Priority: Trivial
>              Labels: beginner, easy-fix
>
> Update README.md for cordova-plugin-test-framework regarding package.json
> Include build step in docs so tests build properly



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message