cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13291) Statusbar does not overlay correctly for iOS 11 and iPhone X
Date Sun, 17 Sep 2017 12:58:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169286#comment-16169286
] 

ASF GitHub Bot commented on CB-13291:
-------------------------------------

Github user BrainstemStudio commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/86
  
    @mhartington Testing now, did not know about viewport-fit will let you know what my test
reveal, if it is unnecessary will remove the property. 


> Statusbar does not overlay correctly for iOS 11 and iPhone X
> ------------------------------------------------------------
>
>                 Key: CB-13291
>                 URL: https://issues.apache.org/jira/browse/CB-13291
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-statusbar
>    Affects Versions: cordova-ios 4.5.0
>         Environment: iOS 11
>            Reporter: Sean Molyneaux
>              Labels: iOS11, iPhoneX
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Status Bar iOS 11 issues:
> # Status Bar does not "crop" correctly on iOS 11 when "StatusBarOverlaysWebView" is set
to true
> # No property or support to allow for web view to use the whole iPhone X screen Top &
Bottom
> Recommendation:
> # Use safeAreaInsets to correctly adjust iOS 11 web view correctly
> # Allow new property to support iPhone X full screen
> Fixes applied (Pending Review)
> #Added new property "StatusBarCropsWebview" to allow iPhone X to display edge to edge
using the "safeAreaInsets" top and bottom. By default this will be set as "true" and crop
the webview below and above the safe areas
> #When "StatusBarCropsWebview" is set to false. The web view will extend to the correcr
full screen on iPhone X. However, is the "StatusBarOverlaysWebView" is to false. This will
only extend the web view at the bottom edge
> #If both StatusBarCropsWebview and “StatusBarOverlaysWebView” are set to false this
will extend the screen top and bottom edge.
> #Added fix for iOS 11 gap problems. If “StatusBarOverlaysWebView” is set to false,
this now fixes the 20px bottom gap. 
> #Added fix for iOS 11 gap after status bar is set to hidden after showing. This now fixes
the 20px bottom gap.
> Screenshots of Fixes:
> 1. Default where StatusBarCropsWebview = true and StatusBarOverlaysWebView = false
> !http://brainstemstudio.com/labs/cordova/patches/statusbar/statusbar-1.png!
> 2. Where StatusBarCropsWebview = false and StatusBarOverlaysWebView = true
> !http://brainstemstudio.com/labs/cordova/patches/statusbar/statusbar-2.png!
> 3. Where StatusBarCropsWebview = false and StatusBarOverlaysWebView = true
> !http://brainstemstudio.com/labs/cordova/patches/statusbar/statusbar-3.png!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message