cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon MacDonald (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13230) Remove service worker from cordova-browser
Date Fri, 01 Sep 2017 00:47:01 GMT

    [ https://issues.apache.org/jira/browse/CB-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149860#comment-16149860
] 

Simon MacDonald commented on CB-13230:
--------------------------------------

I agree, I think we should revert the changes that generate and include service workers in
cordova-browser. 

Initially I was thinking it would make sense to add a service worker by default in Cordova
but after a working with them for a few months it really doesn't make sense in a development
environment. I've done a short dive into various CLI's (Preact-CLI, Vue-CLI and Ionic in this
case) and none of them include service-workers in their development setups. It's only when
they go to production that service-workers are included.

Secondly, I feel as if the immediate goal should be to make it easier for users to take a
PWA they've built and wrap it in a Cordova wrapper for deployment to an app store. The goal
of Cordova to PWA should take a back seat for now.

> Remove service worker from cordova-browser
> ------------------------------------------
>
>                 Key: CB-13230
>                 URL: https://issues.apache.org/jira/browse/CB-13230
>             Project: Apache Cordova
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>            Reporter: Steve Gill
>            Assignee: Herm Wong
>              Labels: browser-next
>             Fix For: 5.1.0
>
>
> It doesn't make sense to include service workers by default in cordova-browser. We are
better off documenting how to add service workers so our users can do that. I think we need
to delete https://github.com/apache/cordova-browser/blob/master/bin/template/www/cordova-sw.js
and remove any references to cordova-sw.js https://github.com/apache/cordova-browser/search?utf8=%E2%9C%93&q=cordova-sw.js&type=



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message