cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13025) Remove use of React in plugins.cordova.io
Date Wed, 13 Sep 2017 00:01:35 GMT

    [ https://issues.apache.org/jira/browse/CB-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163897#comment-16163897
] 

ASF GitHub Bot commented on CB-13025:
-------------------------------------

GitHub user devgeeks opened a pull request:

    https://github.com/apache/cordova-docs/pull/728

    CB-13025 Remove use of React in plugins.cordova.io

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Docs
    
    ### What does this PR do?
    
    Switches https://plugins.cordova.io from React to Preact to comply with Apache Legal.
    
      - uses `preact-compat` for API compatibility (tried to make the smallest
        changes possible)
      - uses `babel` via `babelify` instead of the deprecated `reactify` to transform
        the JSX
      - no longer re-renders the entire app when filtering by platforms or
        sorting has changed
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/devgeeks/cordova-docs CB-13025

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/728.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #728
    
----
commit adf96528f7f4b57ecae40b98d61c14aeff93d0b8
Author: tommy-carlos williams <tommy@devgeeks.org>
Date:   2017-09-12T23:47:41Z

    CB-13025 Remove use of React in plugins.cordova.io
    
    Switched to Preact
    
      - uses `preact-compat` for API compatibility (tried to make the smallest
        changes possible)
      - uses `babel` via `babelify` instead of the deprecated `reactify` to transform
        the JSX
      - no longer re-renders the entire app when filtering by platforms or
        sorting has changed

----


> Remove use of React in plugins.cordova.io
> -----------------------------------------
>
>                 Key: CB-13025
>                 URL: https://issues.apache.org/jira/browse/CB-13025
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: cordova-docs
>            Reporter: Shazron Abdullah
>            Assignee: Tommy-Carlos Williams
>            Priority: Critical
>
> plugins.cordova.io uses React. See if you can use Preact as a drop-in.
> This only affects the website, which we don't "release".
> Apache projects can't use React per LEGAL-303 as covered here and sent to the PMCs: https://issues.apache.org/jira/browse/LEGAL-303?focusedCommentId=16088663&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16088663
> Aug 31 2017 deadline plus NOTICE addition requirements (an email to the PMC should already
be sent with details).
> However, we don't explicitly "include" React, it is a node.js dependency and is installed
at runtime: https://github.com/apache/cordova-docs/blob/03b67269efe58ebd1cf12042ec9616bd1d05ea25/package.json#L47
> Even so, the advisory is that we can't even *use* React so we should remove it accordingly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message