Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 30 Aug 2017 06:11:00 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13092267.1501784571000.155584.1504073460410@Atlassian.JIRA>
In-Reply-To: <JIRA.13092267.1501784571000@Atlassian.JIRA>
References: <JIRA.13092267.1501784571000@Atlassian.JIRA> <JIRA.13092267.1501784571226@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-13145) Create playservices version
 preference in config.xml
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 30 Aug 2017 06:11:08 -0000


    [ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146684#comment-16146684 ] 

ASF subversion and git services commented on CB-13145:
------------------------------------------------------

Commit e5b8a3c3cf73656552cc25bc0f3a315ac6230521 in cordova-lib's branch refs/heads/master from [~auso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=e5b8a3c ]

CB-13145 : added unit tests for mergeVariables from util.js and variable-merge.js and updated after review


> Create playservices version preference in config.xml
> ----------------------------------------------------
>
>                 Key: CB-13145
>                 URL: https://issues.apache.org/jira/browse/CB-13145
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>            Reporter: Steve Gill
>              Labels: backlog, tools-next
>             Fix For: cordova@7.2.0
>
>
> We are seeing an issue in the community of two plugins using different versions of google play services. This causes gradle to error out. We are running into this with the phonegap-push-plugin.
> Potential solution:
> We could create an Android only preference called PlayServicesVersion in config.xml which would control the version of Play Services used for the entire project.
> In config.xml:
> {code}
> <preference name="PlayServicesVersion" value="11.0.1"/>
> {code}
> Then if the push plugin wanted to include the FCM libraries in it's plugin.xml it would do:
> <framework src="com.google.firebase:firebase-messaging:$PlayServicesVersion"/>
> and the cordova-plugin-google-analytics wanted to include Play Services in it's plugin.xml it would do:
> {code}
> <framework src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" />
> {code}
> they would both use the same version of Play Services. This gets around the problem of plugins using + in the framework tag and having two plugins pin different versions of Play Services.
> The + wildcard fails to compile with the following error:
> {code}
> > Failed to apply plugin [id 'com.google.gms.google-services']
>    > For input string: "+"
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org