Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 7 Aug 2017 16:05:00 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13078075.1496860628000.107964.1502121900342@Atlassian.JIRA>
In-Reply-To: <JIRA.13078075.1496860628000@Atlassian.JIRA>
References: <JIRA.13078075.1496860628000@Atlassian.JIRA> <JIRA.13078075.1496860628513@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-12895) Replace jshint with eslint in our
 tools + platforms
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 07 Aug 2017 16:05:08 -0000


    [ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116792#comment-16116792 ] 

ASF subversion and git services commented on CB-12895:
------------------------------------------------------

Commit 0b532b6eeb04c6adbccfea60f132f88de0c14755 in cordova-plugin-dialogs's branch refs/heads/master from [~auso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;h=0b532b6 ]

CB-12895 : setup eslint and removed jshint


> Replace jshint with eslint in our tools + platforms
> ---------------------------------------------------
>
>                 Key: CB-12895
>                 URL: https://issues.apache.org/jira/browse/CB-12895
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: AllComponents
>            Reporter: Steve Gill
>            Assignee: Audrey So
>            Priority: Minor
>              Labels: cordova-next
>
> Based on this proposal
> https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308
> JSHint does minimal checks and JSCS has been deprecated in favor of ESLint.
>  +
>  +I suggest to replace the current style checkers with ESLint. This allows to set much more strict styling rules than at at this moment.
>  +
>  +I recommend using a popular preset, such as [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). Example configuration:
>  +
>  +```yaml
>  +root: true
>  +
>  +extends: airbnb-base
>  +```
>  +
>  +Many styling issues could be fixed by simply running:
>  +
>  +```
>  +./node_modules/.bin/eslint --fix .
>  +```
>  +
>  +
>  +
>  +Optionally the indent could be set to 4 instead of 2, because that's used in the current code base.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org