cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12975) Resort cordova.InAppBrowser.open `options` for better developer experience
Date Tue, 01 Aug 2017 14:39:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109015#comment-16109015
] 

ASF GitHub Bot commented on CB-12975:
-------------------------------------

GitHub user janpio opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/234

    [WIP] CB-12975: (docs) Resort and reword cordova.InAppBrowser.open `options` lists

    This is a followup to #225 to test if I got it working. Do not merge yet please.
    
    
    ### Platforms affected
    n/a, only docs changes
    
    ### What does this PR do?
    Resort and reword cordova.InAppBrowser.open `options` lists for better developer experience.
More reasoning at https://issues.apache.org/jira/browse/CB-12975
    
    ### What testing has been done on this change?
    n/a
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - n/a Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/janpio/cordova-plugin-inappbrowser patch-1b

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #234
    
----
commit 9102757ce1b97ea14ae2c59ef78a44422fe4a1bf
Author: Jan Piotrowski <piotrowski+github@gmail.com>
Date:   2017-07-01T00:41:04Z

    CB-12975 (docs) Resort and reword cordova.InAppBrowser.open `options` lists
    
     for better developer experience

----


> Resort cordova.InAppBrowser.open `options` for better developer experience
> --------------------------------------------------------------------------
>
>                 Key: CB-12975
>                 URL: https://issues.apache.org/jira/browse/CB-12975
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-docs, cordova-plugin-inappbrowser
>            Reporter: Jan Piotrowski
>            Assignee: Filip Maj
>            Priority: Minor
>
> Right now the list of `options` for `cordova.InAppBrowser.open` on https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-inappbrowser/
for the three platforms with additional options is quite random. As a user it is quite simple
to misunderstand the wording and list as e.g. `hidden`only being available for Android (first
item in only the Android list, there "Android only" directly over the line.
> It would be great to resort them in a way, that it is easier to find out which of the
options are available on all (or multiple) of the 3 platforms with additional options. Also
the "only" could be reworded to be less "exclusive".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message