cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12937) [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and annotation
Date Fri, 11 Aug 2017 19:59:01 GMT

    [ https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123951#comment-16123951
] 

ASF subversion and git services commented on CB-12937:
------------------------------------------------------

Commit 077b1dc3c1d72ade9552773ed5a3a4c817800d37 in cordova-ios's branch refs/heads/master
from [~georgiosgalatoulas]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=077b1dc ]

CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno… (#321)

* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation in CDVPlugin
and new notification id CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which
is broadcasted from CDVAppDelegate openURL method.

* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation in CDVPlugin
and new notification id CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which
is broadcasted from CDVAppDelegate openURL method.

CB-12937 - change the NSMutableDictionary to NSDictionary with literal declaration, added
the annotation example in the CDVPlugin

* CB-12937 - revert the literal to ensure nils are not passed in the NSMutable object


> [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and
annotation
> -------------------------------------------------------------------------------------------------
>
>                 Key: CB-12937
>                 URL: https://issues.apache.org/jira/browse/CB-12937
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-ios
>    Affects Versions: cordova-ios@4.4.0
>            Reporter: Georgios Galatoulas
>            Assignee: Shazron Abdullah
>              Labels: backlog, easy-fix
>             Fix For: cordova-ios@4.4.1
>
>
> The App is currently using the 
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url sourceApplication:(NSString*)sourceApplication
annotation:(id)annotation{code} 
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification contains only
the url. 
> I would like to add alongside the current notification a new notification which posts
a NSDictionary instead that contains the url, sourceApplication and annotation and if makes
sense I would also like create a new method like the current handleOpenURL which will provide
the NSDictionary to however wants to use. 
> I propose this solution because it does not introduce any breaking changes. I hope the
impact is small and easy to add to the next release. *The work is already done in my local
fork I will just need to create a branch and ask for a pull request if everyone is happy to
proceed*.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message