cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12930) File plugin getDirectory on windows fails on path ending with slash
Date Wed, 30 Aug 2017 17:39:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147660#comment-16147660
] 

ASF GitHub Bot commented on CB-12930:
-------------------------------------

Github user janpio commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/207#discussion_r136139240
  
    --- Diff: src/windows/FileProxy.js ---
    @@ -751,7 +751,13 @@ module.exports = {
             if (!fs || !validName(path)){
                 fail(FileError.ENCODING_ERR);
                 return;
    -        }           
    +        }
    +	    
    +        //check trailing "/"
    --- End diff --
    
    this actually removes a trailing slash, correct?


> File plugin getDirectory on windows fails on path ending with slash
> -------------------------------------------------------------------
>
>                 Key: CB-12930
>                 URL: https://issues.apache.org/jira/browse/CB-12930
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-file
>            Reporter: Giuseppe La Torre
>            Priority: Minor
>
> On Windows, getDirectory with a path ending with '/' fails.
> On all other platform it works as intended.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message