Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 221DA200CC5 for ; Tue, 11 Jul 2017 11:03:44 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 208C416576D; Tue, 11 Jul 2017 09:03:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6F104165769 for ; Tue, 11 Jul 2017 11:03:43 +0200 (CEST) Received: (qmail 3051 invoked by uid 500); 11 Jul 2017 09:03:42 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 3036 invoked by uid 99); 11 Jul 2017 09:03:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jul 2017 09:03:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 38117195CBC for ; Tue, 11 Jul 2017 09:03:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id mRT9oHg3DEtV for ; Tue, 11 Jul 2017 09:03:41 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D71E8627A1 for ; Tue, 11 Jul 2017 08:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6972CE0D8F for ; Tue, 11 Jul 2017 08:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5563F246B5 for ; Tue, 11 Jul 2017 08:58:00 +0000 (UTC) Date: Tue, 11 Jul 2017 08:58:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-11486) SplashScreenDelay config value parsing incorrect MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 11 Jul 2017 09:03:44 -0000 [ https://issues.apache.org/jira/browse/CB-11486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081904#comment-16081904 ] ASF subversion and git services commented on CB-11486: ------------------------------------------------------ Commit 2db7bac57153e68a0d35f9b8a68ef68fffdbf0bd in cordova-plugin-splashscreen's branch refs/heads/master from [~petermetz] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=2db7bac ] CB-11486 (browser) splashScreenDelay now feed through parseInt to ensure it's an integer by the time it's value is passed in to setTimeout() in hide(). > SplashScreenDelay config value parsing incorrect > ------------------------------------------------ > > Key: CB-11486 > URL: https://issues.apache.org/jira/browse/CB-11486 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser > Affects Versions: 4.1.0 > Environment: browpser platform > Reporter: Peter (Somogyvari) Metz > Priority: Minor > Labels: easyfix > > {code} > splashScreenDelay = cfg.getPreferenceValue('SplashScreenDelay') || splashScreenDelay; > {code} > The variable ```splashScreenDelay``` later assumed to be an integer but after this line it ends up storing an integer as a string, like "3000". > This causes the splash screen delay always to be 0, as in immediate. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org