cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13031) config.xml: android-packageName case-sensitivity
Date Mon, 24 Jul 2017 17:17:27 GMT

    [ https://issues.apache.org/jira/browse/CB-13031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098780#comment-16098780
] 

ASF GitHub Bot commented on CB-13031:
-------------------------------------

Github user filmaj commented on the issue:

    https://github.com/apache/cordova-android/pull/397
  
    Just for the record, here's the full stack trace I get when I try these steps:
    
    ```
    ~/src
    ➔ cordova create testapp com.example.testapp testapp
    Warning: using prerelease version 7.0.2-dev (cordova-lib@7.0.1)
    Creating a new cordova project.
    
    ~/src
    ➔ cd testapp
    
    ~/src/testapp
    ➔ vim config.xml
    
    ~/src/testapp
    ➔ cordova platform add android
    Warning: using prerelease version 7.0.2-dev (cordova-lib@7.0.1)
    Using cordova-fetch for cordova-android@~6.2.2
    Adding android project...
    Creating Cordova project for the Android platform:
    	Path: platforms/android
    	Package: com.example.testapp
    	Name: testapp
    	Activity: MainActivity
    	Android target: android-25
    Subproject Path: CordovaLib
    Android project created with cordova-android@6.2.3
    Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project
    Installing "cordova-plugin-whitelist" for android
    
                   This plugin is only applicable for versions of cordova-android greater
than 4.0. If you have a previous platform version, you do *not* need this plugin since the
whitelist will be built in.
    
    Adding cordova-plugin-whitelist to package.json
    Saved plugin info for "cordova-plugin-whitelist" to config.xml
    ls: no such file or directory: /Users/maj/src/testapp/platforms/android/src/com/example/Testapp/*.java
    
    Error: No Java files found that extend CordovaActivity.
    ```
    
    This patch seems to fix that. However, I noticed that the output even using this patch
still says:
    
    ```
    	Package: com.example.testapp
    ```
    
    Can we update the PR to also print out the correct, overridden package name, if provided?


> config.xml: android-packageName case-sensitivity
> ------------------------------------------------
>
>                 Key: CB-13031
>                 URL: https://issues.apache.org/jira/browse/CB-13031
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android
>    Affects Versions: 7.0.1
>            Reporter: Ronald Klip
>            Assignee: Nikita Matrosov
>            Priority: Minor
>              Labels: osx, windows
>
> In config.xml, setting {{android-packageName}} to a value that only differs from {{id}}
in capitalization causes an error with {{platform add android}} .
> *Example:*
> {{cordova create testapp com.example.testapp testapp}}
> {{cd testapp}}
> (edit config.xml, add android-packageName="com.example.Testapp" to <widget>)
> {{cordova platform add android}}
> *Output:*
> Using cordova-fetch for cordova-android@~6.2.2
> Adding android project...
> Creating Cordova project for the Android platform:
> 	Path: platforms/android
> 	Package: com.example.testapp
> 	Name: testapp
> 	Activity: MainActivity
> 	Android target: android-25
> Subproject Path: CordovaLib
> Android project created with cordova-android@6.2.3
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project
> Installing "cordova-plugin-whitelist" for android
>                This plugin is only applicable for versions of cordova-android greater
than 4.0. If you have a previous platform version, you do *not* need this plugin since the
whitelist will be built in.
>           
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> ls: no such file or directory: /Users/ronald987/dev/apps/testapp/platforms/android/src/com/example/Testapp/*.java
> {color:red}Error: No Java files found that extend CordovaActivity.{color}
> </output>
> The directory and the .java indeed don't exist. In platforms/android/src there's only
an org directory. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message