cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13020) plugman filters out nohooks option
Date Thu, 13 Jul 2017 19:15:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086247#comment-16086247
] 

ASF GitHub Bot commented on CB-13020:
-------------------------------------

GitHub user wildabeast opened a pull request:

    https://github.com/apache/cordova-lib/pull/575

    CB-13020: (plugman) install filters out nohooks

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    n/a
    
    ### What does this PR do?
    
    fixes CB-13020: plugman filters out nohooks opt
    
    ### What testing has been done on this change?
    
    manual
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wildabeast/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #575
    
----
commit 6234355db76342b6fb3045b9a3b23e08f42a92bd
Author: Ryan Willoughby <ryan.willoughby@adobe.com>
Date:   2017-07-13T19:10:04Z

    CB-13020: (plugman) install filters out nohooks

----


> plugman filters out nohooks option
> ----------------------------------
>
>                 Key: CB-13020
>                 URL: https://issues.apache.org/jira/browse/CB-13020
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>    Affects Versions: 7.0.1
>            Reporter: Ryan Willoughby
>
> plugman install curates the options object prior to sending it to the install function,
and it doesn't support the nohooks option. before_plugin_install and after_plugin_install
can get triggered even if nohooks is set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message