cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12987) Hidden folders (.github, .svn) are added to the Windows platform assembly
Date Wed, 05 Jul 2017 10:28:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074550#comment-16074550
] 

ASF GitHub Bot commented on CB-12987:
-------------------------------------

GitHub user paymicro opened a pull request:

    https://github.com/apache/cordova-windows/pull/234

    CB-12987 - Hidden folders (.github, .svn) are added to the Windows platform assembly

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Folders starting with '.' are excluded from the project
    
    ### What testing has been done on this change?
    Manual testing
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paymicro/cordova-windows Bugs/bug457206

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #234
    
----
commit 871ce3cdf5f93d577e4cfc3f65658ce2bf0eddc6
Author: Pavel Yakovlev (Akvelon) <v-payako@microsoft.com>
Date:   2017-07-05T10:20:43Z

    fixes bug CB-12987 - Hidden folders (.github, .svn) are added to the Windows platform
assembly

----


> Hidden folders (.github, .svn) are added to the Windows platform assembly
> -------------------------------------------------------------------------
>
>                 Key: CB-12987
>                 URL: https://issues.apache.org/jira/browse/CB-12987
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>    Affects Versions: 7.0.1
>         Environment: Windows 10 with cordova 7.0.1
>            Reporter: Pavel Yakovlev
>            Assignee: Jesse MacFadyen
>            Priority: Minor
>              Labels: prepare
>
> Hidden files within the project's www directory (in this case folder .svn) will be correctly
ignored if building for target iOS or Android, but they will be included if the target is
Windows.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message