cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12985) Change `InAppBrowser.open(url, target, options)` to get `options` as object, not string
Date Fri, 14 Jul 2017 23:26:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088280#comment-16088280
] 

ASF subversion and git services commented on CB-12985:
------------------------------------------------------

Commit 34d879e0ca56e32b8224160bba49b20e1a969721 in cordova-osx's branch refs/heads/master
from [~auso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-osx.git;h=34d879e ]

CB-12985 : updated to use eslint format


> Change `InAppBrowser.open(url, target, options)` to get `options` as object, not string
> ---------------------------------------------------------------------------------------
>
>                 Key: CB-12985
>                 URL: https://issues.apache.org/jira/browse/CB-12985
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-inappbrowser
>            Reporter: Jan Piotrowski
>
> `InAppBrowser.open(url, target, options)` currently expects `options` to be a string,
formatted in a special way (no spaces).
> It would be much easier to maintain this if `options` would be a plain Javascript object.
> The yes|no values could be changed to true|false of course.
> (During this change all options should probably also be unified to use camelCase)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message