cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kerri Shotts (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12985) Change `InAppBrowser.open(url, target, options)` to get `options` as object, not string
Date Wed, 05 Jul 2017 19:26:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075271#comment-16075271
] 

Kerri Shotts commented on CB-12985:
-----------------------------------

As I understand it, {{options}} is configured in this manner due to matching the {{window.open}}
API, which does the same thing. That said, being able to handle either the string form or
an options object would be nice.

> Change `InAppBrowser.open(url, target, options)` to get `options` as object, not string
> ---------------------------------------------------------------------------------------
>
>                 Key: CB-12985
>                 URL: https://issues.apache.org/jira/browse/CB-12985
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-inappbrowser
>            Reporter: Jan Piotrowski
>
> `InAppBrowser.open(url, target, options)` currently expects `options` to be a string,
formatted in a special way (no spaces).
> It would be much easier to maintain this if `options` would be a plain Javascript object.
> The yes|no values could be changed to true|false of course.
> (During this change all options should probably also be unified to use camelCase)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message