cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12944) Platform's spec is ignored in config.xml if package.json doesn't contain dependency for platform
Date Fri, 28 Jul 2017 18:25:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105437#comment-16105437
] 

ASF GitHub Bot commented on CB-12944:
-------------------------------------

Github user filmaj commented on the issue:

    https://github.com/apache/cordova-lib/pull/565
  
    OK, with the testing all cleaned up in lib now, we can come back to this PR.
    
    @matrosov-nikita let's add a unit test for this please.
    
    Ping @stevengill / @audreyso for review / FYI.


> Platform's spec is ignored in config.xml if package.json doesn't contain dependency for
platform
> ------------------------------------------------------------------------------------------------
>
>                 Key: CB-12944
>                 URL: https://issues.apache.org/jira/browse/CB-12944
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>    Affects Versions: Master
>            Reporter: Nikita Matrosov
>            Assignee: Nikita Matrosov
>
> Steps to reproduce with cordova@7.0.2-dev:
> 1) Create app with package.json contains empty dependencies object: "dependencies": {}
> (e.g. it's default for Visual Studio Cordova template)
> 2) Add entry into config.xml: <engine name="windows" spec="https://github.com/apache/cordova-windows.git#4.4.x"
/>
> 3) cordova platform add windows
> So, if package.json dependencies keys don't include windows or cordova-windows, we should
look for a spec in config.xml.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message