Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 28 Jun 2017 15:11:01 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13083170.1498662239000.125096.1498662661406@Atlassian.JIRA>
In-Reply-To: <JIRA.13083170.1498662239000@Atlassian.JIRA>
References: <JIRA.13083170.1498662239000@Atlassian.JIRA> <JIRA.13083170.1498662239437@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-12964) When Pictures folder does not exist,
 plugin cannot take a photo.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 28 Jun 2017 15:11:07 -0000


    [ https://issues.apache.org/jira/browse/CB-12964?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D160666=
54#comment-16066654 ]=20

ASF GitHub Bot commented on CB-12964:
-------------------------------------

GitHub user joseluisballesterosdelval opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/273

    CB-12964: (android) Fix of bug when Pictures folder did not exist.

    If someone had removed Pictures folder in android, plugin failed trying=
 to move there the new photo. This happened because plugin did not check th=
e existence of this folder, and if not, it did not complete the folder tree=
.
   =20
    <!--
    Please make sure the checklist boxes are all checked before submitting =
the PR. The checklist
    is intended as a quick reference, for complete details please see our C=
ontributor Guidelines:
   =20
    http://cordova.apache.org/contribute/contribute_guidelines.html
   =20
    Thanks!
    -->
   =20
    ### Platforms affected
    Android
   =20
    ### What does this PR do?
    It makes plugin to create Pictures folder, if it has enough permissions=
 (if not, an exception will be thrown and caught in the usual way), because=
 until this time, in case of user had deleted this folder, the plugin faile=
d.
   =20
    ### What testing has been done on this change?
    I have tested that in an Android application using this plugin, when Pi=
ctures folder was deleted, the plugin works normally after change and not b=
efore.
   =20
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.h=
tml) in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug wi=
th resolving file paths", where CB-xxxx is the JIRA ID & "android" is the p=
latform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joseluisballesterosdelval/cordova-plugin-=
camera master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #273
   =20
----
commit edda4657522a1ae5fd611cf23a99140b42c9251e
Author: Jos=C3=A9 Luis Ballesteros del Val <joseluis.ballesterosdelval@gmai=
l.com>
Date:   2017-06-28T14:38:45Z

    CB-12964: (android) Fix of bug when Pictures folder did not exist.
   =20
    If someone had removed Pictures folder in android, plugin failed trying=
 to move there the new photo. This happened because plugin did not check th=
e existence of this folder, and if not, it did not complete the folder tree=
.

----


> When Pictures folder does not exist, plugin cannot take a photo.
> ----------------------------------------------------------------
>
>                 Key: CB-12964
>                 URL: https://issues.apache.org/jira/browse/CB-12964
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-camera
>         Environment: Android
>            Reporter: Jos=C3=A9 Luis Ballesteros del Val
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If someone has removed Pictures folder in android, plugin fails trying to=
 move there the new photo. This happens because plugin does not check the e=
xistence of this folder, and if not, it does not complete the folder tree.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org