Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B3E94200CAE for ; Wed, 21 Jun 2017 10:01:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B29DE160BE2; Wed, 21 Jun 2017 08:01:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 05756160BD0 for ; Wed, 21 Jun 2017 10:01:02 +0200 (CEST) Received: (qmail 5146 invoked by uid 500); 21 Jun 2017 08:01:02 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 5135 invoked by uid 99); 21 Jun 2017 08:01:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jun 2017 08:01:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A7907D507F for ; Wed, 21 Jun 2017 08:01:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.011 X-Spam-Level: X-Spam-Status: No, score=-100.011 tagged_above=-999 required=6.31 tests=[SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id qkjBe9cEgZRU for ; Wed, 21 Jun 2017 08:01:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E0ADA5F2F1 for ; Wed, 21 Jun 2017 08:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7172BE059C for ; Wed, 21 Jun 2017 08:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2F22E21942 for ; Wed, 21 Jun 2017 08:01:00 +0000 (UTC) Date: Wed, 21 Jun 2017 08:01:00 +0000 (UTC) From: "Shazron Abdullah (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-12940) Use deployment-target for platform version in Podfile MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 21 Jun 2017 08:01:03 -0000 [ https://issues.apache.org/jira/browse/CB-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057126#comment-16057126 ] Shazron Abdullah commented on CB-12940: --------------------------------------- Line: https://github.com/apache/cordova-ios/blob/4490abf273ec6d12810c8ff5ea16d197c58ecd4b/bin/templates/scripts/cordova/lib/Podfile.js#L94 The Podfile constructor needs to be passed the deployment-target from the project config ConfigParser object here: https://github.com/apache/cordova-ios/blob/df5441df874183d3d36b64e84969ebc7f0838f05/bin/templates/scripts/cordova/Api.js#L259 > Use deployment-target for platform version in Podfile > ----------------------------------------------------- > > Key: CB-12940 > URL: https://issues.apache.org/jira/browse/CB-12940 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Affects Versions: cordova-ios@4.4.0 > Reporter: Todd Miller > Assignee: Shazron Abdullah > Fix For: cordova-ios@4.4.1 > > > The current Podfile.js script is hardcoded to set the platform ios version to 8.0. However, there are some pods that require 9.0 or they will fail to install. The deployment-target preference should be honored and used when generating the Podfile. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org