Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 20 Jun 2017 12:23:00 +0000 (UTC)
From: "Georgios Galatoulas (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13081116.1497961188000.57648.1497961380161@Atlassian.JIRA>
In-Reply-To: <JIRA.13081116.1497961188000@Atlassian.JIRA>
References: <JIRA.13081116.1497961188000@Atlassian.JIRA> <JIRA.13081116.1497961188266@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-12937) [iOS] Add new CDVPlugin method to
 handle incoming urls including sourceApplication and annotation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 20 Jun 2017 12:23:06 -0000


    [ https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055666#comment-16055666 ] 

Georgios Galatoulas commented on CB-12937:
------------------------------------------

Please let me know if everyone if happy with this improvement task. Please let me know if there is anything wrong with this or else I am happy to do the work as I am interested to have it in the next release if it is possible as it is a blocker for my work.

> [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and annotation
> -------------------------------------------------------------------------------------------------
>
>                 Key: CB-12937
>                 URL: https://issues.apache.org/jira/browse/CB-12937
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-ios
>    Affects Versions: cordova-ios@4.4.0
>            Reporter: Georgios Galatoulas
>            Assignee: Shazron Abdullah
>              Labels: easy-fix
>
> The App is currently using the 
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url sourceApplication:(NSString*)sourceApplication annotation:(id)annotation{code} 
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification contains only the url. 
> I would like to add alongside the current notification a new notification which posts a NSDictionary instead that contains the url, sourceApplication and annotation and if makes sense I would also like create a new method like the current handleOpenURL which will provide the NSDictionary to however wants to use. 
> I propose this solution because it does not introduce any breaking changes. I hope the impact is small and easy to add to the next release. The work is already done in my local fork I will just need to create a branch and ask for a pull request if everyone is happy to proceed.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org