Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 75117200CB5 for ; Wed, 7 Jun 2017 00:25:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 73B08160BC6; Tue, 6 Jun 2017 22:25:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C1E06160BD3 for ; Wed, 7 Jun 2017 00:25:21 +0200 (CEST) Received: (qmail 5862 invoked by uid 500); 6 Jun 2017 22:25:21 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 5823 invoked by uid 99); 6 Jun 2017 22:25:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2017 22:25:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7590ECFF16 for ; Tue, 6 Jun 2017 22:25:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.21 X-Spam-Level: X-Spam-Status: No, score=-99.21 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id hnLylRxI3O3a for ; Tue, 6 Jun 2017 22:25:19 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 329DF5F642 for ; Tue, 6 Jun 2017 22:25:19 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6F2F2E0630 for ; Tue, 6 Jun 2017 22:25:18 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 208B821E0B for ; Tue, 6 Jun 2017 22:25:18 +0000 (UTC) Date: Tue, 6 Jun 2017 22:25:18 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-12882) captureVideo doesn't close camera picker and doesn't show alert message about prohibited camera usage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 06 Jun 2017 22:25:22 -0000 [ https://issues.apache.org/jira/browse/CB-12882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039771#comment-16039771 ] ASF GitHub Bot commented on CB-12882: ------------------------------------- Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120496658 --- Diff: src/ios/CDVCapture.m --- @@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath forCallbackId:(NSString*)c return [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsArray:fileArray]; } +- (void)showAlertIfAccessProhibeted +{ --- End diff -- For styling consistency, can we keep the opening brace of a function on the same line as the function? > captureVideo doesn't close camera picker and doesn't show alert message about prohibited camera usage > ----------------------------------------------------------------------------------------------------- > > Key: CB-12882 > URL: https://issues.apache.org/jira/browse/CB-12882 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media-capture > Affects Versions: 1.4.2 > Reporter: Sergii Stotskyi > Labels: ios > > *Steps to reproduce*: > # Create a simple application which calls `captureVideo()` method > # Deploy application to real device > # Click on button which starts video capturing > # Click "No" when it asks permissions for camera > *Expected result*: > camera picker is animated out. And every time when user clicks on capture video alert is shown as in `cordova-plugin-camera`: Access to the camera has been prohibited, please enable it in the Settings app to continue. And 2 buttons are shown: OK, Settings > *Actual result*: > camera picker is not hidden. It's possible to click on record button and record black screen. Eventually video is saved and viewed -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org