Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 19 Jun 2017 08:37:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13036059.1484791177000.45820.1497861420188@Atlassian.JIRA>
In-Reply-To: <JIRA.13036059.1484791177000@Atlassian.JIRA>
References: <JIRA.13036059.1484791177000@Atlassian.JIRA> <JIRA.13036059.1484791177730@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-12367) Modernize styling of iOS InAppBrowser
 view
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 19 Jun 2017 08:37:06 -0000


    [ https://issues.apache.org/jira/browse/CB-12367?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D160536=
23#comment-16053623 ]=20

ASF GitHub Bot commented on CB-12367:
-------------------------------------

Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/210#discussi=
on_r122648718
 =20
    --- Diff: src/ios/CDVInAppBrowser.m ---
    @@ -539,115 +545,212 @@ -(void)dealloc {
     - (void)createViews
     {
         // We create the views in code for primarily for ease of upgrades =
and not requiring an external .xib to be included
    +    UIBarButtonItem* flexibleSpaceButton =3D [[UIBarButtonItem alloc] =
initWithBarButtonSystemItem:UIBarButtonSystemItemFlexibleSpace target:nil a=
ction:nil];
    +    UIBarButtonItem* fixedSpaceButton =3D [[UIBarButtonItem alloc] ini=
tWithBarButtonSystemItem:UIBarButtonSystemItemFixedSpace target:nil action:=
nil];
    +    fixedSpaceButton.width =3D 20;
    =20
    -    CGRect webViewBounds =3D self.view.bounds;
    -    BOOL toolbarIsAtBottom =3D ![_browserOptions.toolbarposition isEqu=
alToString:kInAppBrowserToolbarBarPositionTop];
    -    webViewBounds.size.height -=3D _browserOptions.location ? FOOTER_H=
EIGHT : TOOLBAR_HEIGHT;
    -    self.webView =3D [[UIWebView alloc] initWithFrame:webViewBounds];
    +    self.webView =3D [self buildWebView];
    +    self.spinner =3D [self buildSpinner];
    +    self.toolbar =3D [self buildToolbar];
    +
    +    self.addressLabel =3D [self buildAddressLabel];
    +    self.addressBar =3D [self buildAddressBar:self.addressLabel];
    =20
    -    self.webView.autoresizingMask =3D (UIViewAutoresizingFlexibleWidth=
 | UIViewAutoresizingFlexibleHeight);
    +    self.closeButton =3D [self buildCloseButton];
    +    self.forwardButton =3D [self buildForwardButton];
    +    self.backButton =3D [self buildBackButton];
    +
    +    [self.toolbar setItems:@[self.closeButton, flexibleSpaceButton, se=
lf.backButton, fixedSpaceButton, self.forwardButton]];
    +
    +    self.view.backgroundColor =3D [UIColor whiteColor];
    +
    +    if (IsAtLeastiOSVersion(@"7.0")) {
    --- End diff --
   =20
    Any reason we should worry about older iOS versions anymore? The latest=
 iOS platform release cordova-ios@4.4.0 only supports iOS 9 and up.=20
   =20
    To support older iOS versions (so users can fall back to older plugin v=
ersions for their platform version), you can add engine tag support like so=
:=20
    1. https://github.com/phonegap/phonegap-plugin-push/blob/464636b9ae257a=
fc712cfebcc1ed11425590c509/plugin.xml#L14-L18
    2. https://github.com/phonegap/phonegap-plugin-push/blob/464636b9ae257a=
fc712cfebcc1ed11425590c509/package.json#L33-L51


> Modernize styling of iOS InAppBrowser view
> ------------------------------------------
>
>                 Key: CB-12367
>                 URL: https://issues.apache.org/jira/browse/CB-12367
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-inappbrowser
>    Affects Versions: 1.6.1
>            Reporter: Reid Beels
>
> I've been working on a branch that brings several visual and configuratio=
n improvements to the iOS InAppBrowser view, along with a little refactorin=
g of the view setup code.
> This PR:
> * breaks up the large {{CDVInAppBrowserViewController createView}} method=
 into several smaller helper methods to handle the creation of individual s=
ubviews
> * gives the {{addressLabel}} a wrapping view to provide flexibility of ba=
ckground color / padding
> * changes the default toolbar style from {{UIBarStyleBlackOpaque}} to {{U=
IBarStyleDefault}} to match the system default
> * adds a {{toolbarstyle}} configuration option that accepts {{default}} o=
r {{black}}
> * sets the status bar style and background color to match the {{toolbarst=
yle}}, so that top toolbars can blend nicely into the status bar
> * replaces the unicode navigation arrows (=E2=97=84=E2=96=BA) with drawn =
arrows that match those used in Safari
> * adds a {{tintcolor}} configuration option that accepts hex strings like=
 {{F8A027}}. If not provided, or set to {{default}}, controls will be rende=
red in the default iOS blue, or in white when {{toolbarstyle=3Dblack}} is s=
et.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org