Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 9 Jun 2017 22:24:18 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12967159.1462905401000.43398.1497047058159@Atlassian.JIRA>
In-Reply-To: <JIRA.12967159.1462905401000@Atlassian.JIRA>
References: <JIRA.12967159.1462905401000@Atlassian.JIRA> <JIRA.12967159.1462905401199@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-11244) Update Android Project Structure to
 be more compatible with Android Studio
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 09 Jun 2017 22:24:28 -0000


    [ https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045130#comment-16045130 ] 

ASF GitHub Bot commented on CB-11244:
-------------------------------------

GitHub user infil00p opened a pull request:

    https://github.com/apache/cordova-android/pull/384

    CB-11244: Studio project cleanup

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Modernizes Android and makes it so we can do Modern Android Development
    
    ### What testing has been done on this change?
    * Manual Testing with Plugman
    * Dev against e2e tests (upgrade still fails, help plz)
    * Talked to Fil regarding JUnit Test running 
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/infil00p/cordova-android StudioProjectCleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #384
    
----
commit 6167130bac0630f8a8359ed491381caa7da45871
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-03-30T19:41:44Z

    Adding the Studio Builder to build a project based on Android Studio,
    and deleting Ant, since Google does not support Ant Builds anymore.
    Sorry guys!

commit 2ef15bd2172f265c44b8447a8e2f119d1590fda3
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-03-30T20:38:18Z

    Moving Android Manifest finding to the Gradle and Studio builders.

commit 09a4ed45ec2c959a5424c85d1e3df04f344eb664
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-03T22:21:48Z

    Changing this so we pass lint

commit 5a40dcd86ed8bd21ca611a66ee13170bed099739
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-04T20:38:40Z

    Fixing linting issues

commit 3795b65bced7c8634cade5f00bfe2d42349250c9
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-04T22:18:46Z

    Setting up the create command so we actually have all the directories in the right place, and define default variables in the top level build.gradle

commit f2396de53e250cd0ad9b8bb2020ce11eaef16ffe
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-04T22:34:42Z

    Updating gradle version in the build file

commit 02c07de746b39a587613b531e3fbdcb833d442e9
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-04T22:42:58Z

    Managed to get the project to mostly compile, still need to re-work the build command to add the app project

commit c8f328fe2a9b6d05ad543b32989182bb612e9d0a
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-11T20:47:40Z

    Made changes so cordova/build builds with the new project.  Need to work on plugin installation.

commit 7db18f8b361369d10237f5159154dbae3f0c3f4d
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-11T21:41:27Z

    Fix the overwriting of Fil's fix, blargh

commit cc2d1fd9ae59e5aca10ff5271ef637b6b6897eee
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-01-04T19:48:18Z

    CB-11244: Changing directory creation, will most likely hide this behind a flag for the next release of Cordova-Android, and then make it default in the next major pending feedback

commit 844dc7f3df7f830cf562535ef9f5f5fc15471ca1
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-18T21:29:02Z

    Changing the project to add the app directory as a dependency

commit 2df146df4f918067eb325ca1d50639045f5003ed
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-18T21:48:56Z

    JsHint Fixes, deleting unused methods

commit c1ea8ec88576586a7385dd06d5d62897f9142b4e
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-19T18:50:55Z

    Fixed the specification of the builders in the run command by getting build to check what was being passed from run

commit 17416dfd1df16da9b4c0715ec6280961c7b9d91b
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-21T23:27:26Z

    Fixing the Android Studio detection and making it automatically pick the right builder, good for upgrading Cordova

commit e30968e15a8aadbc6cc20d4b483f27f1c580ac15
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-04-22T00:02:27Z

    Updated AndroidStudio to only look for the app directory to determine studio status

commit a17a5b891f98417d149bacbf8307412fa8c03a34
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-05-31T17:23:35Z

    CB-11244: Setup Api.js to support multiple builders based on project structure

commit a5ca7089eaa2e8825dca9f7c2140c2f62b5d618c
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-05-31T17:37:47Z

    Fixing lint errors

----


> Update Android Project Structure to be more compatible with Android Studio
> --------------------------------------------------------------------------
>
>                 Key: CB-11244
>                 URL: https://issues.apache.org/jira/browse/CB-11244
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-android
>            Reporter: Joe Bowser
>            Assignee: Joe Bowser
>              Labels: CordovaAndroidSix
>
> Currently our existing Android projects have the old Android Project structure created by default, even for new projects, which makes no sense since we no longer support Eclipse as the default project editor and have moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for projects and dependencies to work more like how modern Android projects work and to remove as much custom Gradle code as possible.  This would also allow us in the future to move towards having Android Plugin code work as Android Libraries with Resources instead of just copying things across, which gives us the ability to add JUnit tests and bundled resources.  This would dramatically increase the quality of plugins such as InAppBrowser, and third party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would be tricky to do.  However, the benefits at this point would greatly outweigh the costs of maintaining the old project structure.  The old cordova-common code in Cordova-Android 5.0.x would allow for plugins in the short term to work with both projects until we get the new project structure ready.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org