cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12966) cordova-ios Podfile template does not escape project names containing a single quote
Date Fri, 30 Jun 2017 14:31:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070192#comment-16070192
] 

ASF GitHub Bot commented on CB-12966:
-------------------------------------

Github user joshdholtz commented on the issue:

    https://github.com/apache/cordova-ios/pull/324
  
    @renatoalencar I have no idea why the tests are not passing. It seems like other tests
aren't passing either. You can use this by doing something like...
    
    ```
    ionic platform add https://github.com/joshdholtz/cordova-ios.git
    ```
    or
    ```
    cordova platform add https://github.com/joshdholtz/cordova-ios.git
    ```


> cordova-ios Podfile template does not escape project names containing a single quote
> ------------------------------------------------------------------------------------
>
>                 Key: CB-12966
>                 URL: https://issues.apache.org/jira/browse/CB-12966
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-ios
>    Affects Versions: cordova-ios@4.4.0, cordova-ios@5.0.0
>         Environment: iOS platform
>            Reporter: Josh Holtz
>            Assignee: Shazron Abdullah
>            Priority: Minor
>              Labels: ios, patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The Podfile template does not escape single quotes for project names when generating
the Podfile. This will cause a syntax error in the Podfile since the target and project are
single quoted strings. The solution is to escape the single quotes in the project name before
writing them to the Podfile.
> I already have a fix for this issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message