cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12948) Add a warning to updateProject for iOS
Date Sat, 24 Jun 2017 01:06:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061711#comment-16061711
] 

ASF GitHub Bot commented on CB-12948:
-------------------------------------

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-ios/pull/322

    CB-12948 - Add a warning to updateProject for iOS

    ### Platforms affected
    
    self
    
    ### What does this PR do?
    
    Remove the `cordova platform update` functionality of this platform, and provide text
on what to do instead (remove, then add the platform). We treat the platforms folder as a
build artifact.
    
    ### What testing has been done on this change?
    
    Created a project, added an older platform, and updated to the platform in this PR. It
prints out the error text expected.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-ios CB-12948

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #322
    
----
commit 2b8d9d251571f043b58d5649b7a0d21b345c9222
Author: Shazron Abdullah <shazron@gmail.com>
Date:   2017-06-24T00:57:48Z

    CB-12948 - Add a warning to updateProject for iOS

----


> Add a warning to updateProject for iOS
> --------------------------------------
>
>                 Key: CB-12948
>                 URL: https://issues.apache.org/jira/browse/CB-12948
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-ios
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>             Fix For: cordova-ios@4.4.1
>
>
> Right now a `cordova platform update` (CLI) or update scripts (non-CLI) will treat platforms
as a build artifact.
> They use the same function:
> https://github.com/apache/cordova-ios/blob/df5441df874183d3d36b64e84969ebc7f0838f05/bin/lib/create.js#L261-L273
> There is no warning to the user at all. We should:
> 1. Add a warning but don't do the update
> 2. The warning has an instruction on how to override the warning and do the update (new
flag?)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message