cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12948) Add a warning (plus override flag) to updateProject for iOS
Date Sat, 24 Jun 2017 00:50:02 GMT

    [ https://issues.apache.org/jira/browse/CB-12948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061701#comment-16061701
] 

Shazron Abdullah commented on CB-12948:
---------------------------------------

Adding the flag seems to be problematic. The only flag that is passed down is "link". I don't
think it's worth it to muck with cordova-lib code to just add this special flag.

I think updatePlatform should just fail with the error message on what to do, just like a
"name" change in config.xml does:
https://github.com/apache/cordova-ios/blob/8c77a0b991ace06b470dba9496a24e6ef75c2be3/bin/templates/scripts/cordova/lib/prepare.js#L239-L248

> Add a warning (plus override flag) to updateProject for iOS
> -----------------------------------------------------------
>
>                 Key: CB-12948
>                 URL: https://issues.apache.org/jira/browse/CB-12948
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-ios
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>             Fix For: cordova-ios@4.4.1
>
>
> Right now a `cordova platform update` (CLI) or update scripts (non-CLI) will treat platforms
as a build artifact.
> They use the same function:
> https://github.com/apache/cordova-ios/blob/df5441df874183d3d36b64e84969ebc7f0838f05/bin/lib/create.js#L261-L273
> There is no warning to the user at all. We should:
> 1. Add a warning but don't do the update
> 2. The warning has an instruction on how to override the warning and do the update (new
flag?)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message