cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-12937) [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and annotation
Date Wed, 21 Jun 2017 14:09:00 GMT


ASF GitHub Bot commented on CB-12937:

Github user Giorgioshooter commented on a diff in the pull request:
    --- Diff: CordovaLib/Classes/Public/CDVAppDelegate.m ---
    @@ -79,8 +79,16 @@ - (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
             return NO;
    +    NSDictionary *openURLData = @{
    +            @"url": url,
    +            @"sourceApplication": sourceApplication,
    +            @"annotation": annotation
    --- End diff --
    Good point @pbudzinsky .  I should revert to my original commit where I did explicit checks
on sourceApplication and annotation then. sourceApplication can be nil too

> [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and
> -------------------------------------------------------------------------------------------------
>                 Key: CB-12937
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-ios
>    Affects Versions: cordova-ios@4.4.0
>            Reporter: Georgios Galatoulas
>            Assignee: Shazron Abdullah
>              Labels: easy-fix
>             Fix For: cordova-ios@4.5.0
> The App is currently using the 
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url sourceApplication:(NSString*)sourceApplication
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification contains only
the url. 
> I would like to add alongside the current notification a new notification which posts
a NSDictionary instead that contains the url, sourceApplication and annotation and if makes
sense I would also like create a new method like the current handleOpenURL which will provide
the NSDictionary to however wants to use. 
> I propose this solution because it does not introduce any breaking changes. I hope the
impact is small and easy to add to the next release. *The work is already done in my local
fork I will just need to create a branch and ask for a pull request if everyone is happy to

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message