cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12905) LaunchBrowser promise in linux, not resolved until the browser process terminates.
Date Fri, 09 Jun 2017 16:44:18 GMT

    [ https://issues.apache.org/jira/browse/CB-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044663#comment-16044663
] 

ASF GitHub Bot commented on CB-12905:
-------------------------------------

Github user matrosov-nikita commented on a diff in the pull request:

    https://github.com/apache/cordova-browser/pull/31#discussion_r121171609
  
    --- Diff: node_modules/cordova-serve/src/exec.js ---
    @@ -29,7 +29,15 @@ var child_process = require('child_process'),
     module.exports = function (cmd, opt_cwd) {
         var d = Q.defer();
         try {
    +        // In Linux, the callback is not called until the process terminates.
    +        // If the error is not caused within 2 seconds, then the promise will be resolved.
    +        var timer = setTimeout(() => {
    +            if (process.platform == 'linux') {
    --- End diff --
    
    use `===` instead of `==`


> LaunchBrowser promise in linux, not resolved until the browser process terminates.
> ----------------------------------------------------------------------------------
>
>                 Key: CB-12905
>                 URL: https://issues.apache.org/jira/browse/CB-12905
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-browser, cordova-serve
>    Affects Versions: 6.5.0, 7.0.1
>         Environment: OS: Ubuntu 16.04.2 LTS
> cordova: 6.5.0
> simulate: 0.3.12
> node: v7.10.0
> npm: 4.6.1
>            Reporter: Pavel Yakovlev
>            Priority: Minor
>
> LaunchBrowser promise in linux, not resolved until the browser process terminates.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message