cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12905) LaunchBrowser promise in linux, not resolved until the browser process terminates.
Date Fri, 09 Jun 2017 14:00:24 GMT

    [ https://issues.apache.org/jira/browse/CB-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044463#comment-16044463
] 

ASF GitHub Bot commented on CB-12905:
-------------------------------------

GitHub user paymicro opened a pull request:

    https://github.com/apache/cordova-browser/pull/31

    CB-12905: (linux) Fix issue with freezing after launching the browser

    In Linux, the callback is not called until the process terminates.
    If the error is not caused within 2 seconds, then the promise will be resolved.
    
    ### Platforms affected
    - Linux
    
    ### What does this PR do?
    - If the [error after launching the browser](https://github.com/Microsoft/cordova-simulate/issues/245)
is not caused within 2 seconds, then the promise will be resolved. 
    
    ### What testing has been done on this change?
    - manual testing launching browsers in Linux, Windows and MacOs
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paymicro/cordova-browser Bugs/bug446896-simulate-in-linux

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-browser/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit 17ca6c585afab25b68e868ecc0a13e55e803dc40
Author: Pavel Yakovlev (Akvelon) <v-payako@microsoft.com>
Date:   2017-06-09T13:13:19Z

    In Linux, the callback is not called until the process terminates.
    If the error is not caused within 2 seconds, then the promise will be resolved.

----


> LaunchBrowser promise in linux, not resolved until the browser process terminates.
> ----------------------------------------------------------------------------------
>
>                 Key: CB-12905
>                 URL: https://issues.apache.org/jira/browse/CB-12905
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-browser, cordova-serve
>    Affects Versions: 6.5.0, 7.0.1
>         Environment: OS: Ubuntu 16.04.2 LTS
> cordova: 6.5.0
> simulate: 0.3.12
> node: v7.10.0
> npm: 4.6.1
>            Reporter: Pavel Yakovlev
>            Priority: Minor
>
> LaunchBrowser promise in linux, not resolved until the browser process terminates.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message