cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12901) Remove lazy loading of node modules from cordova tooling
Date Tue, 20 Jun 2017 09:52:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055478#comment-16055478
] 

ASF GitHub Bot commented on CB-12901:
-------------------------------------

Github user purplecabbage commented on the issue:

    https://github.com/apache/cordova-cli/pull/283
  
    That is correct!
    The cordova-lib changes are already on master, so together they are broken without these
changes.


> Remove lazy loading of node modules from cordova tooling
> --------------------------------------------------------
>
>                 Key: CB-12901
>                 URL: https://issues.apache.org/jira/browse/CB-12901
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: cordova-common, cordova-lib
>            Reporter: Filip Maj
>            Assignee: Filip Maj
>
> There are various {{addProperty*}} methods that execute {{require}} at runtime. While
this improves load time and only loads modules that are necessary, it also makes it harder
to test, as spying and mocking is more difficult.
> The 300ms load time improvement, in the best case, is not worth the difficulty in writing
unit tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message