cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation
Date Fri, 09 Jun 2017 06:38:18 GMT

    [ https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044028#comment-16044028
] 

ASF GitHub Bot commented on CB-12766:
-------------------------------------

Github user uloco commented on the issue:

    https://github.com/apache/cordova-lib/pull/558
  
    You should also keep the last line if it's empty in both, `package.json` and `config.xml`.
    The [POSIX standard](http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206)
defines a line like this:
    
    > 3.206 Line
    > A sequence of zero or more non- <newline> characters plus a terminating <newline>
character.
    
    A lot of us are developing on UNIX systems and are following this practice. It would be
nice, if you could help us keeping it consistent.


> Cordova CLI changes package.json indentation
> --------------------------------------------
>
>                 Key: CB-12766
>                 URL: https://issues.apache.org/jira/browse/CB-12766
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-cli, cordova-lib
>    Affects Versions: 7.0.0
>            Reporter: Remco Haszing
>            Assignee: Kerri Shotts
>            Priority: Minor
>              Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json several times.
In this process the indentation of package.json alternates between 2 and 4 spaces. The final
result is an indentation of 4 spaces, which conflicts with the indentation of 2 spaces that
npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message