cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation
Date Tue, 06 Jun 2017 05:00:25 GMT

    [ https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038180#comment-16038180
] 

ASF subversion and git services commented on CB-12766:
------------------------------------------------------

Commit c3f6c9df1046e6609db0ff730a9be62222f302d5 in cordova-common's branch refs/heads/master
from [~remcohaszing]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=c3f6c9d ]

CB-12766 Consistently write JSON with 2 spaces indentation

JSON was written with 4 spaces indentation and even a tab at some
point. Most NodeJS tools write their JSON configuration with an
indentation of 2 spaces. Most notably npm does this, which writes to
package.json, as does Cordova. This caused unnecessary changes in
package.json.

 This closes #558


> Cordova CLI changes package.json indentation
> --------------------------------------------
>
>                 Key: CB-12766
>                 URL: https://issues.apache.org/jira/browse/CB-12766
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-cli, cordova-lib
>    Affects Versions: 7.0.0
>            Reporter: Remco Haszing
>            Assignee: Kerri Shotts
>            Priority: Minor
>              Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json several times.
In this process the indentation of package.json alternates between 2 and 4 spaces. The final
result is an indentation of 4 spaces, which conflicts with the indentation of 2 spaces that
npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message