cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12605) `cordova requirements` call fails with cordova-android@master if there is no `C:\Program Files\Android\` directory
Date Tue, 20 Jun 2017 23:58:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056689#comment-16056689
] 

ASF GitHub Bot commented on CB-12605:
-------------------------------------

GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-android/pull/387

    CB-12605 In Windows get Android studio path from the registry

    ### Platforms affected
    Android on windows
    
    ### What does this PR do?
    Allows installs of Android Studio in places other than C://
    
    ### What testing has been done on this change?
    Tested with and without registry value present
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-android CB-12605

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #387
    
----
commit 656fc194cef72dc597c4528287bcc3ca3c025fee
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-06-20T23:54:32Z

    CB-12605 In Windows get Android studio path from the registry

----


> `cordova requirements` call fails with cordova-android@master if there is no `C:\Program
Files\Android\` directory
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-12605
>                 URL: https://issues.apache.org/jira/browse/CB-12605
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android
>            Reporter: Alexander Sorokin
>            Assignee: Jesse MacFadyen
>              Labels: found-by-ci, triaged
>
> `cordova requirements` call fails with cordova-android@master if there is no `C:\Program
Files\Android\` directory
> Example output.
> {noformat}
> Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: installed Google Inc.:Google APIs:19,android-25,android-24,android-23,android-22,android-21,android-19
> Gradle: not installed 
> ENOENT: no such file or directory, scandir 'C:\Program Files\Android'
> Error: Some of requirements check failed
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message